bpo-27620: The escape key closes IDLE's config dialog as canceled

This commit is contained in:
Zackery Spytz 2020-04-24 18:57:52 -06:00
parent 0e80b561d4
commit 71c0f7acbd
2 changed files with 7 additions and 7 deletions

View File

@ -80,11 +80,10 @@ class ConfigDialog(Toplevel):
self.transient(parent)
self.protocol("WM_DELETE_WINDOW", self.cancel)
self.fontpage.fontlist.focus_set()
# XXX Decide whether to keep or delete these key bindings.
# Key bindings for this dialog.
# self.bind('<Escape>', self.Cancel) #dismiss dialog, no save
# self.bind('<Alt-a>', self.Apply) #apply changes, save
# self.bind('<F1>', self.Help) #context help
self.bind('<Escape>', self.cancel) # Dismiss dialog, no save
self.bind('<Alt-a>', self.apply) # Apply changes, save
self.bind('<F1>', self.help) # Context help
# Attach callbacks after loading config to avoid calling them.
tracers.attach()
@ -174,7 +173,7 @@ class ConfigDialog(Toplevel):
self.apply()
self.destroy()
def apply(self):
def apply(self, event=None):
"""Apply config changes and leave dialog open.
Methods:
@ -187,7 +186,7 @@ class ConfigDialog(Toplevel):
self.save_all_changed_extensions()
self.activate_config_changes()
def cancel(self):
def cancel(self, event=None):
"""Dismiss config dialog.
Methods:
@ -202,7 +201,7 @@ class ConfigDialog(Toplevel):
self.grab_release()
super().destroy()
def help(self):
def help(self, event=None):
"""Create textview for config dialog help.
Attributes accessed:

View File

@ -0,0 +1 @@
The escape key now closes IDLE's config dialog as canceled.