traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* Eliminate duplicate call to PyObject_Size(). 

(Spotted by Michael Hudson.)

* Now that "selflen" is no longer inside a loop, it should not be a
  register variable.
This commit is contained in:
Raymond Hettinger 2004-03-12 15:30:38 +00:00
parent 2d783e9b16
commit 6e058d70ef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Objects/listobject.c
View File

@ -650,12 +650,13 @@ listappend(PyListObject *self, PyObject *v)
static int static int
listextend_internal(PyListObject *self, PyObject *b) listextend_internal(PyListObject *self, PyObject *b)
{ {
register int selflen = PyList_GET_SIZE(self); int selflen = PyList_GET_SIZE(self);
int blen; int blen;
register int i; register int i;
PyObject **src, **dest; PyObject **src, **dest;
if (PyObject_Size(b) == 0) { blen = PyObject_Size(b);
if (blen == 0) {
/* short circuit when b is empty */ /* short circuit when b is empty */
Py_DECREF(b); Py_DECREF(b);
return 0; return 0;
@ -679,7 +680,6 @@ listextend_internal(PyListObject *self, PyObject *b)
} }
} }
blen = PyObject_Size(b);
if (list_resize(self, selflen + blen) == -1) { if (list_resize(self, selflen + blen) == -1) {
Py_DECREF(b); Py_DECREF(b);
return -1; return -1;