bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091)

Contributed by Bradley Laney.
This commit is contained in:
Bradley Laney 2018-07-10 05:46:44 -04:00 committed by Tal Einat
parent 5ac9e6eee5
commit 6b490b5db4
2 changed files with 2 additions and 3 deletions

View File

@ -241,8 +241,7 @@ class OtherFileTests:
# Test for appropriate errors mixing read* and iteration
for methodname, args in methods:
f = self.open(TESTFN, 'rb')
if next(f) != filler:
self.fail, "Broken testfile"
self.assertEqual(next(f), filler)
meth = getattr(f, methodname)
meth(*args) # This simply shouldn't fail
f.close()

View File

@ -306,7 +306,7 @@ class BasicAuthTests(unittest.TestCase):
try:
self.assertTrue(urllib.request.urlopen(self.server_url))
except urllib.error.HTTPError:
self.fail("Basic auth failed for the url: %s", self.server_url)
self.fail("Basic auth failed for the url: %s" % self.server_url)
def test_basic_auth_httperror(self):
ah = urllib.request.HTTPBasicAuthHandler()