From 6a1d84e2b37291b7e3bc5ddad14a60aed430e404 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 6 Jun 2017 19:40:41 +0200 Subject: [PATCH] bpo-30557: Fix test_faulthandler (#1969) On Windows 8, 8.1 and 10 at least, the exit code is the exception code (no bit is cleared). --- Lib/test/test_faulthandler.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_faulthandler.py b/Lib/test/test_faulthandler.py index c965d67db34..e2fcb2b852d 100644 --- a/Lib/test/test_faulthandler.py +++ b/Lib/test/test_faulthandler.py @@ -777,8 +777,10 @@ class FaultHandlerTests(unittest.TestCase): """ ) self.assertEqual(output, []) - # Actual exception code has bit 4 cleared - self.assertEqual(exitcode, exc & ~0x10000000) + # On Windows older than 7 SP1, the actual exception code has + # bit 29 cleared. + self.assertIn(exitcode, + (exc, exc & ~0x10000000)) @unittest.skipUnless(MS_WINDOWS, 'specific to Windows') def test_disable_windows_exc_handler(self):