Issue #12364: Fix a hang in concurrent.futures.ProcessPoolExecutor.

This commit is contained in:
Ross Lagerwall 2012-01-08 08:29:40 +02:00
parent 645a0dd6f7
commit 66e2fb68ac
3 changed files with 11 additions and 6 deletions

View File

@ -213,9 +213,7 @@ def _queue_management_worker(executor_reference,
work_item.future.set_exception(result_item.exception) work_item.future.set_exception(result_item.exception)
else: else:
work_item.future.set_result(result_item.result) work_item.future.set_result(result_item.result)
continue # Check whether we should start shutting down.
# If we come here, we either got a timeout or were explicitly woken up.
# In either case, check whether we should start shutting down.
executor = executor_reference() executor = executor_reference()
# No more work items can be added if: # No more work items can be added if:
# - The interpreter is shutting down OR # - The interpreter is shutting down OR
@ -234,9 +232,6 @@ def _queue_management_worker(executor_reference,
p.join() p.join()
call_queue.close() call_queue.close()
return return
else:
# Start shutting down by telling a process it can exit.
shutdown_one_process()
del executor del executor
_system_limits_checked = False _system_limits_checked = False

View File

@ -109,6 +109,12 @@ class ExecutorShutdownTest(unittest.TestCase):
self.assertFalse(err) self.assertFalse(err)
self.assertEqual(out.strip(), b"apple") self.assertEqual(out.strip(), b"apple")
def test_hang_issue12364(self):
fs = [self.executor.submit(time.sleep, 0.1) for _ in range(50)]
self.executor.shutdown()
for f in fs:
f.result()
class ThreadPoolShutdownTest(ThreadPoolMixin, ExecutorShutdownTest): class ThreadPoolShutdownTest(ThreadPoolMixin, ExecutorShutdownTest):
def _prime_executor(self): def _prime_executor(self):

View File

@ -97,6 +97,10 @@ Core and Builtins
Library Library
------- -------
- Issue #12364: Fix a hang in concurrent.futures.ProcessPoolExecutor.
The hang would occur when retrieving the result of a scheduled future after
the executor had been shut down.
- Issue #13502: threading: Fix a race condition in Event.wait() that made it - Issue #13502: threading: Fix a race condition in Event.wait() that made it
return False when the event was set and cleared right after. return False when the event was set and cleared right after.