bpo-35814: Allow same r.h.s. in annotated assignments as in normal ones (GH-11667)

This commit is contained in:
Ivan Levkivskyi 2019-01-25 01:39:19 +00:00 committed by GitHub
parent 1396d8fab4
commit 62c35a8a8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 23 additions and 6 deletions

View File

@ -40,7 +40,7 @@ small_stmt: (expr_stmt | del_stmt | pass_stmt | flow_stmt |
import_stmt | global_stmt | nonlocal_stmt | assert_stmt)
expr_stmt: testlist_star_expr (annassign | augassign (yield_expr|testlist) |
('=' (yield_expr|testlist_star_expr))*)
annassign: ':' test ['=' test]
annassign: ':' test ['=' (yield_expr|testlist)]
testlist_star_expr: (test|star_expr) (',' (test|star_expr))* [',']
augassign: ('+=' | '-=' | '*=' | '@=' | '/=' | '%=' | '&=' | '|=' | '^=' |
'<<=' | '>>=' | '**=' | '//=')

View File

@ -445,6 +445,15 @@ class GrammarTests(unittest.TestCase):
exec('X: str', {}, CNS2())
self.assertEqual(nonloc_ns['__annotations__']['x'], str)
def test_var_annot_rhs(self):
ns = {}
exec('x: tuple = 1, 2', ns)
self.assertEqual(ns['x'], (1, 2))
stmt = ('def f():\n'
' x: int = yield')
exec(stmt, ns)
self.assertEqual(list(ns['f']()), [None])
def test_funcdef(self):
### [decorators] 'def' NAME parameters ['->' test] ':' suite
### decorator: '@' dotted_name [ '(' [arglist] ')' ] NEWLINE

View File

@ -166,7 +166,7 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase):
with self.assertRaises(SyntaxError):
exec("x, *y, z: int = range(5)", {}, {})
with self.assertRaises(SyntaxError):
exec("t: tuple = 1, 2", {}, {})
exec("x: int = 1, y = 2", {}, {})
with self.assertRaises(SyntaxError):
exec("u = v: int", {}, {})
with self.assertRaises(SyntaxError):

View File

@ -0,0 +1,2 @@
Allow same right hand side expressions in annotated assignments as in normal ones.
In particular, ``x: Tuple[int, int] = 1, 2`` (without parentheses on the right) is now allowed.

View File

@ -3163,7 +3163,12 @@ ast_for_expr_stmt(struct compiling *c, const node *n)
}
else {
ch = CHILD(ann, 3);
expr3 = ast_for_expr(c, ch);
if (TYPE(ch) == testlist) {
expr3 = ast_for_testlist(c, ch);
}
else {
expr3 = ast_for_expr(c, ch);
}
if (!expr3) {
return NULL;
}

View File

@ -498,8 +498,9 @@ static arc arcs_17_2[2] = {
{31, 3},
{0, 2},
};
static arc arcs_17_3[1] = {
{26, 4},
static arc arcs_17_3[2] = {
{50, 4},
{9, 4},
};
static arc arcs_17_4[1] = {
{0, 4},
@ -508,7 +509,7 @@ static state states_17[5] = {
{1, arcs_17_0},
{1, arcs_17_1},
{2, arcs_17_2},
{1, arcs_17_3},
{2, arcs_17_3},
{1, arcs_17_4},
};
static arc arcs_18_0[2] = {