From 61eda7260ac9fcdb6c5f066eb48dc344544bdfa6 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Sun, 15 Jan 2017 10:06:52 +0000 Subject: [PATCH] Fixed #29132: Updated shlex to work better with punctuation chars in POSIX mode. Thanks to Evan_ for the report and patch. --- Lib/shlex.py | 10 +++++----- Lib/test/test_shlex.py | 8 ++++++++ 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/Lib/shlex.py b/Lib/shlex.py index e87266f8dd0..2c9786c517a 100644 --- a/Lib/shlex.py +++ b/Lib/shlex.py @@ -232,11 +232,6 @@ class shlex: break # emit current token else: continue - elif self.posix and nextchar in self.quotes: - self.state = nextchar - elif self.posix and nextchar in self.escape: - escapedstate = 'a' - self.state = nextchar elif self.state == 'c': if nextchar in self.punctuation_chars: self.token += nextchar @@ -245,6 +240,11 @@ class shlex: self._pushback_chars.append(nextchar) self.state = ' ' break + elif self.posix and nextchar in self.quotes: + self.state = nextchar + elif self.posix and nextchar in self.escape: + escapedstate = 'a' + self.state = nextchar elif (nextchar in self.wordchars or nextchar in self.quotes or self.whitespace_split): self.token += nextchar diff --git a/Lib/test/test_shlex.py b/Lib/test/test_shlex.py index 3936c97c8b9..fd35788e81b 100644 --- a/Lib/test/test_shlex.py +++ b/Lib/test/test_shlex.py @@ -273,6 +273,14 @@ class ShlexTest(unittest.TestCase): # white space self.assertEqual(list(s), ['a', '&&', 'b', '||', 'c']) + def testPunctuationWithPosix(self): + """Test that punctuation_chars and posix behave correctly together.""" + # see Issue #29132 + s = shlex.shlex('f >"abc"', posix=True, punctuation_chars=True) + self.assertEqual(list(s), ['f', '>', 'abc']) + s = shlex.shlex('f >\\"abc\\"', posix=True, punctuation_chars=True) + self.assertEqual(list(s), ['f', '>', '"abc"']) + def testEmptyStringHandling(self): """Test that parsing of empty strings is correctly handled.""" # see Issue #21999