traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-39580: add check for CLI installation on macOS (GH-20271) 

Adds a simple check for whether or not the package is being installed in the GUI or using installer on the command line. This addresses an issue where CLI-based software management tools (such as Munki) unexpectedly open Finder windows into a GUI session during installation runs.
This commit is contained in:
Rick Heil 2020-06-25 06:37:40 -04:00 committed by GitHub
parent 1931e64de1
commit 5f190d2cc6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Mac/BuildScript/scripts/postflight.documentation
View File

@ -12,7 +12,9 @@ SHARE_DOCDIR_TO_FWK="../../.."
# make link in /Applications/Python m.n/ for Finder users # make link in /Applications/Python m.n/ for Finder users
if [ -d "${APPDIR}" ]; then if [ -d "${APPDIR}" ]; then
ln -fhs "${FWK_DOCDIR}/index.html" "${APPDIR}/Python Documentation.html" ln -fhs "${FWK_DOCDIR}/index.html" "${APPDIR}/Python Documentation.html"
open "${APPDIR}" || true # open the applications folder if [ "${COMMAND_LINE_INSTALL}" != 1 ]; then
open "${APPDIR}" || true # open the applications folder
fi
fi fi
# make share/doc link in framework for command line users # make share/doc link in framework for command line users

2
Misc/NEWS.d/next/macOS/2020-06-25-06-09-00.bpo-39580.N_vJ9h.rst Normal file
View File

@ -0,0 +1,2 @@
Avoid opening Finder window if running installer from the command line.
Patch contributed by Rick Heil.