traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

issue 3633: Solaris allows fullwidth Unicode digits in isxdigit, so 

rewrite float.fromhex to only allow ASCII hex digits on all platforms.
(Tests for this are already present, but the test_float failures
on Solaris hadn't been noticed before.)

Reviewed by Antoine Pitrou.
This commit is contained in:
Mark Dickinson 2008-08-21 21:38:38 +00:00
parent 892429b08b
commit 5c2bb1a7d4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Objects/floatobject.c
View File

@ -1126,7 +1126,6 @@ char_from_hex(int x)
static int
hex_from_char(char c) {
int x;
assert(isxdigit(c));
switch(c) {
case '0':
x = 0;
@ -1355,12 +1354,12 @@ float_fromhex(PyObject *cls, PyObject *arg)
/* coefficient: <integer> [. <fraction>] */
coeff_start = s;
while (isxdigit(*s))
while (hex_from_char(*s) >= 0)
s++;
s_store = s;
if (*s == '.') {
s++;
while (isxdigit(*s))
while (hex_from_char(*s) >= 0)
s++;
coeff_end = s-1;
}
@ -1382,10 +1381,10 @@ float_fromhex(PyObject *cls, PyObject *arg)
exp_start = s;
if (*s == '-' || *s == '+')
s++;
if (!isdigit(*s))
if (!('0' <= *s && *s <= '9'))
goto parse_error;
s++;
while (isdigit(*s))
while ('0' <= *s && *s <= '9')
s++;
exp = strtol(exp_start, NULL, 10);
}