[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs" (GH-16724) (GH-16728)

This reverts commit 87bd2071c7.

The reason for revert is a regression caused by the change in 3.8.0rc1, see bpo-38449 for more details.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d87300)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
This commit is contained in:
Abhilash Raj 2019-10-12 09:58:11 -07:00 committed by GitHub
parent 1da648aceb
commit 5a638a8055
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 11 deletions

View File

@ -114,8 +114,7 @@ class MimeTypes:
but non-standard types.
"""
url = os.fspath(url)
p = urllib.parse.urlparse(url)
scheme, url = p.scheme, p.path
scheme, url = urllib.parse._splittype(url)
if scheme == 'data':
# syntax of data URLs:
# dataurl := "data:" [ mediatype ] [ ";base64" ] "," data

View File

@ -51,14 +51,6 @@ class MimeTypesTestCase(unittest.TestCase):
eq(self.db.guess_type('foo.xul', strict=False), ('text/xul', None))
eq(self.db.guess_extension('image/jpg', strict=False), '.jpg')
def test_url(self):
result = self.db.guess_type('http://host.html')
msg = 'URL only has a host name, not a file'
self.assertSequenceEqual(result, (None, None), msg)
result = self.db.guess_type('http://example.com/host.html')
msg = 'Should be text/html'
self.assertSequenceEqual(result, ('text/html', None), msg)
def test_guess_all_types(self):
eq = self.assertEqual
unless = self.assertTrue

View File

@ -744,7 +744,7 @@ class HandlerTests(unittest.TestCase):
["foo", "bar"], "", None),
("ftp://localhost/baz.gif;type=a",
"localhost", ftplib.FTP_PORT, "", "", "A",
[], "baz.gif", "image/gif"),
[], "baz.gif", None), # XXX really this should guess image/gif
]:
req = Request(url)
req.timeout = None

View File

@ -0,0 +1,2 @@
Revert GH-15522, which introduces a regression in
:meth:`mimetypes.guess_type` due to improper handling of filenames as urls.