Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by Thomas

Jarosch.
2011-09-29 19:46:37 +02:00 · 2011-09-29 19:46:37 +02:00 · 5a4a109694
parent b86ecf4bd1
commit 5a4a109694
3 changed files with 5 additions and 0 deletions
--- a/Misc/ACKS
+++ b/Misc/ACKS
@ -436,6 +436,7 @@ Bertrand Janin
 Geert Jansen
 Jack Jansen
 Bill Janssen
+Thomas Jarosch
 Drew Jenkins
 Flemming Kjær Jensen
 MunSic Jeong
--- a/Misc/NEWS
+++ b/Misc/NEWS
@ -82,6 +82,9 @@ Tests
 Extension Modules
 -----------------

+- Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by
+  Thomas Jarosch.
+
 - Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.
  Thanks to Suman Saha for finding the bug and providing a patch.

--- a/Modules/ossaudiodev.c
+++ b/Modules/ossaudiodev.c
@ -129,6 +129,7 @@ newossobject(PyObject *arg)
    }

    if (ioctl(fd, SNDCTL_DSP_GETFMTS, &afmts) == -1) {
+        close(fd);
        PyErr_SetFromErrnoWithFilename(PyExc_IOError, devicename);
        return NULL;
    }