From 52d42503d5f7e763264b03f12785c46a467c196b Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Tue, 21 Sep 2010 16:08:27 +0000 Subject: [PATCH] Issue #2643: msync() is not called anymore when deallocating an open mmap object, only munmap(). --- Misc/NEWS | 3 +++ Modules/mmapmodule.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index 139ab0188fe..cdd9ef7060c 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -58,6 +58,9 @@ Core and Builtins Library ------- +- Issue #2643: msync() is not called anymore when deallocating an open mmap + object, only munmap(). + - logging: Changed LoggerAdapter implementation internally, to make it easier to subclass in a useful way. diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index 8c5c8ac80a0..3413f17ebd3 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -125,7 +125,6 @@ mmap_object_dealloc(mmap_object *m_obj) if (m_obj->fd >= 0) (void) close(m_obj->fd); if (m_obj->data!=NULL) { - msync(m_obj->data, m_obj->size, MS_SYNC); munmap(m_obj->data, m_obj->size); } #endif /* UNIX */