Explain the purpose of the b_needsfree flag. This answers Neals

question (well, two months too late).
This commit is contained in:
Thomas Heller 2007-03-22 20:33:04 +00:00
parent 02b8feea9f
commit 50d1d0bad5
1 changed files with 6 additions and 1 deletions

View File

@ -2181,7 +2181,12 @@ static void CData_MallocBuffer(CDataObject *obj, StgDictObject *dict)
if ((size_t)dict->size <= sizeof(obj->b_value)) { if ((size_t)dict->size <= sizeof(obj->b_value)) {
/* No need to call malloc, can use the default buffer */ /* No need to call malloc, can use the default buffer */
obj->b_ptr = (char *)&obj->b_value; obj->b_ptr = (char *)&obj->b_value;
/* XXX(nnorwitz): shouldn't b_needsfree be 0? */ /* The b_needsfree flag does not mean that we actually did
call PyMem_Malloc to allocate the memory block; instead it
means we are the *owner* of the memory and are responsible
for freeing resources associated with the memory. This is
also the reason that b_needsfree is exposed to Python.
*/
obj->b_needsfree = 1; obj->b_needsfree = 1;
} else { } else {
/* In python 2.4, and ctypes 0.9.6, the malloc call took about /* In python 2.4, and ctypes 0.9.6, the malloc call took about