bpo-36969: Make PDB args command display keyword only arguments (GH-13452)

(cherry picked from commit bf457c7d82)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
This commit is contained in:
Miss Islington (bot) 2019-05-20 15:34:23 -07:00 committed by GitHub
parent 3887932e10
commit 50b3f205d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 7 deletions

View File

@ -1133,9 +1133,9 @@ class Pdb(bdb.Bdb, cmd.Cmd):
""" """
co = self.curframe.f_code co = self.curframe.f_code
dict = self.curframe_locals dict = self.curframe_locals
n = co.co_argcount n = co.co_argcount + co.co_kwonlyargcount
if co.co_flags & 4: n = n+1 if co.co_flags & inspect.CO_VARARGS: n = n+1
if co.co_flags & 8: n = n+1 if co.co_flags & inspect.CO_VARKEYWORDS: n = n+1
for i in range(n): for i in range(n):
name = co.co_varnames[i] name = co.co_varnames[i]
if name in dict: if name in dict:

View File

@ -77,9 +77,13 @@ def test_pdb_basic_commands():
... print('...') ... print('...')
... return foo.upper() ... return foo.upper()
>>> def test_function3(arg=None, *, kwonly=None):
... pass
>>> def test_function(): >>> def test_function():
... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace() ... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
... ret = test_function_2('baz') ... ret = test_function_2('baz')
... test_function3(kwonly=True)
... print(ret) ... print(ret)
>>> with PdbTestInput([ # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE >>> with PdbTestInput([ # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
@ -97,10 +101,13 @@ def test_pdb_basic_commands():
... 'jump 8', # jump over second for loop ... 'jump 8', # jump over second for loop
... 'return', # return out of function ... 'return', # return out of function
... 'retval', # display return value ... 'retval', # display return value
... 'next', # step to test_function3()
... 'step', # stepping into test_function3()
... 'args', # display function args
... 'continue', ... 'continue',
... ]): ... ]):
... test_function() ... test_function()
> <doctest test.test_pdb.test_pdb_basic_commands[1]>(3)test_function() > <doctest test.test_pdb.test_pdb_basic_commands[2]>(3)test_function()
-> ret = test_function_2('baz') -> ret = test_function_2('baz')
(Pdb) step (Pdb) step
--Call-- --Call--
@ -123,14 +130,14 @@ def test_pdb_basic_commands():
[EOF] [EOF]
(Pdb) bt (Pdb) bt
... ...
<doctest test.test_pdb.test_pdb_basic_commands[2]>(18)<module>() <doctest test.test_pdb.test_pdb_basic_commands[3]>(21)<module>()
-> test_function() -> test_function()
<doctest test.test_pdb.test_pdb_basic_commands[1]>(3)test_function() <doctest test.test_pdb.test_pdb_basic_commands[2]>(3)test_function()
-> ret = test_function_2('baz') -> ret = test_function_2('baz')
> <doctest test.test_pdb.test_pdb_basic_commands[0]>(1)test_function_2() > <doctest test.test_pdb.test_pdb_basic_commands[0]>(1)test_function_2()
-> def test_function_2(foo, bar='default'): -> def test_function_2(foo, bar='default'):
(Pdb) up (Pdb) up
> <doctest test.test_pdb.test_pdb_basic_commands[1]>(3)test_function() > <doctest test.test_pdb.test_pdb_basic_commands[2]>(3)test_function()
-> ret = test_function_2('baz') -> ret = test_function_2('baz')
(Pdb) down (Pdb) down
> <doctest test.test_pdb.test_pdb_basic_commands[0]>(1)test_function_2() > <doctest test.test_pdb.test_pdb_basic_commands[0]>(1)test_function_2()
@ -168,6 +175,16 @@ def test_pdb_basic_commands():
-> return foo.upper() -> return foo.upper()
(Pdb) retval (Pdb) retval
'BAZ' 'BAZ'
(Pdb) next
> <doctest test.test_pdb.test_pdb_basic_commands[2]>(4)test_function()
-> test_function3(kwonly=True)
(Pdb) step
--Call--
> <doctest test.test_pdb.test_pdb_basic_commands[1]>(1)test_function3()
-> def test_function3(arg=None, *, kwonly=None):
(Pdb) args
arg = None
kwonly = True
(Pdb) continue (Pdb) continue
BAZ BAZ
""" """

View File

@ -0,0 +1,2 @@
PDB command `args` now display keyword only arguments. Patch contributed by
Rémi Lapeyre.