From 4be1e24933db192b3cf95e102a46673bb3312dc3 Mon Sep 17 00:00:00 2001 From: R David Murray Date: Tue, 17 Dec 2013 21:13:16 -0500 Subject: [PATCH] #19855: uuid.get_node now looks on the PATH for executables on unix. Patch by Serhiy Storchaka. --- Lib/uuid.py | 55 +++++++++++++++++++++++++++-------------------------- Misc/NEWS | 4 ++++ 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/Lib/uuid.py b/Lib/uuid.py index d5c3160fdfd..7705a8ad409 100644 --- a/Lib/uuid.py +++ b/Lib/uuid.py @@ -312,34 +312,35 @@ class UUID(object): return int((self.int >> 76) & 0xf) def _find_mac(command, args, hw_identifiers, get_index): - import os - for dir in ['', '/sbin/', '/usr/sbin']: - executable = os.path.join(dir, command) - if not os.path.exists(executable): - continue + import os, shutil + executable = shutil.which(command) + if executable is None: + path = os.pathsep.join(('/sbin', '/usr/sbin')) + executable = shutil.which(command, path=path) + if executable is None: + return None - try: - # LC_ALL to get English output, 2>/dev/null to - # prevent output on stderr - cmd = 'LC_ALL=C %s %s 2>/dev/null' % (executable, args) - with os.popen(cmd) as pipe: - for line in pipe: - words = line.lower().split() - for i in range(len(words)): - if words[i] in hw_identifiers: - try: - return int( - words[get_index(i)].replace(':', ''), 16) - except (ValueError, IndexError): - # Virtual interfaces, such as those provided by - # VPNs, do not have a colon-delimited MAC address - # as expected, but a 16-byte HWAddr separated by - # dashes. These should be ignored in favor of a - # real MAC address - pass - except IOError: - continue - return None + try: + # LC_MESSAGES to get English output, 2>/dev/null to + # prevent output on stderr + cmd = 'LC_MESSAGES=C %s %s 2>/dev/null' % (executable, args) + with os.popen(cmd) as pipe: + for line in pipe: + words = line.lower().split() + for i in range(len(words)): + if words[i] in hw_identifiers: + try: + return int( + words[get_index(i)].replace(':', ''), 16) + except (ValueError, IndexError): + # Virtual interfaces, such as those provided by + # VPNs, do not have a colon-delimited MAC address + # as expected, but a 16-byte HWAddr separated by + # dashes. These should be ignored in favor of a + # real MAC address + pass + except IOError: + pass def _ifconfig_getnode(): """Get the hardware address on Unix by running ifconfig.""" diff --git a/Misc/NEWS b/Misc/NEWS index 1b58dea47f5..0d05366361f 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -29,6 +29,10 @@ Core and Builtins Library ------- +- Issue #19855: uuid.getnode() on Unix now looks on the PATH for the + executables used to find the mac address, with /sbin and /usr/sbin as + fallbacks. + - Issue #20007: HTTPResponse.read(0) no more prematurely closes connection. Original patch by Simon Sapin.