From 4bcfa317eec0eb479586be10f326aefb994ccf28 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Thu, 20 Sep 2001 06:08:24 +0000 Subject: [PATCH] Since inspect.isfunction(obj) is a precondition for calling inspect.getargspec(obj), test isfunction() directly in pydoc.py instead of trying to indirectly deduce isfunction() in pydoc by virtue of failing a combination of other tests. This shouldn't have any visible effect, except perhaps to squash a TypeError death if there was some path thru this code that was inferring isfunction() by mistake. --- Lib/pydoc.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Lib/pydoc.py b/Lib/pydoc.py index b8050318b04..ecc39c59647 100755 --- a/Lib/pydoc.py +++ b/Lib/pydoc.py @@ -659,15 +659,15 @@ TT { font-family: lucidatypewriter, lucida console, courier } reallink = realname title = '%s = %s' % ( anchor, name, reallink) - if inspect.isbuiltin(object) or inspect.ismethoddescriptor(object): - argspec = '(...)' - else: + if inspect.isfunction(object): args, varargs, varkw, defaults = inspect.getargspec(object) argspec = inspect.formatargspec( args, varargs, varkw, defaults, formatvalue=self.formatvalue) if realname == '': decl = 'lambda' argspec = argspec[1:-1] # remove parentheses + else: + argspec = '(...)' decl = title + argspec + (note and self.small(self.grey( '%s' % note))) @@ -916,15 +916,15 @@ class TextDoc(Doc): cl.__dict__[realname] is object): skipdocs = 1 title = self.bold(name) + ' = ' + realname - if inspect.isbuiltin(object) or inspect.ismethoddescriptor(object): - argspec = '(...)' - else: + if inspect.isfunction(object): args, varargs, varkw, defaults = inspect.getargspec(object) argspec = inspect.formatargspec( args, varargs, varkw, defaults, formatvalue=self.formatvalue) if realname == '': title = 'lambda' argspec = argspec[1:-1] # remove parentheses + else: + argspec = '(...)' decl = title + argspec + note if skipdocs: