simply use the Python version for pyexpat.__version__ #12221

This commit is contained in:
Benjamin Peterson 2011-05-31 18:59:49 -05:00
parent f14e42077c
commit 4ba009d8dc
2 changed files with 10 additions and 21 deletions

View File

@ -7,6 +7,11 @@ What's New in Python 2.7.2?
*Release date: 2011-06-XX* *Release date: 2011-06-XX*
Extension Modules
-----------------
- Issue #1221: Make pyexpat.__version__ equal to the Python version.
What's New in Python 2.7.2 release candidate 1? What's New in Python 2.7.2 release candidate 1?
=============================================== ===============================================

View File

@ -1792,26 +1792,6 @@ static struct PyMethodDef pyexpat_methods[] = {
PyDoc_STRVAR(pyexpat_module_documentation, PyDoc_STRVAR(pyexpat_module_documentation,
"Python wrapper for Expat parser."); "Python wrapper for Expat parser.");
/* Return a Python string that represents the version number without the
* extra cruft added by revision control, even if the right options were
* given to the "cvs export" command to make it not include the extra
* cruft.
*/
static PyObject *
get_version_string(void)
{
static char *rcsid = "$Revision$";
char *rev = rcsid;
int i = 0;
while (!isdigit(Py_CHARMASK(*rev)))
++rev;
while (rev[i] != ' ' && rev[i] != '\0')
++i;
return PyString_FromStringAndSize(rev, i);
}
/* Initialization function for the module */ /* Initialization function for the module */
#ifndef MODULE_NAME #ifndef MODULE_NAME
@ -1841,6 +1821,7 @@ MODULE_INITFUNC(void)
PyObject *modelmod_name; PyObject *modelmod_name;
PyObject *model_module; PyObject *model_module;
PyObject *sys_modules; PyObject *sys_modules;
PyObject *version;
static struct PyExpat_CAPI capi; static struct PyExpat_CAPI capi;
PyObject* capi_object; PyObject* capi_object;
@ -1872,7 +1853,10 @@ MODULE_INITFUNC(void)
Py_INCREF(&Xmlparsetype); Py_INCREF(&Xmlparsetype);
PyModule_AddObject(m, "XMLParserType", (PyObject *) &Xmlparsetype); PyModule_AddObject(m, "XMLParserType", (PyObject *) &Xmlparsetype);
PyModule_AddObject(m, "__version__", get_version_string()); version = PyString_FromString(PY_VERSION);
if (!version)
return;
PyModule_AddObject(m, "__version__", version);
PyModule_AddStringConstant(m, "EXPAT_VERSION", PyModule_AddStringConstant(m, "EXPAT_VERSION",
(char *) XML_ExpatVersion()); (char *) XML_ExpatVersion());
{ {