traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-33723: Fix test_time.test_thread_time() (GH-8267) 

The test failed on AMD64 Debian root 3.x buildbot because the busy
loop of 100 ms only increased time.thread_time() by 19.9 ms which is
smaller than 20 ms. Modify the test to tolerate a delta of at least
15 ms instead of 20 ms.
(cherry picked from commit d6345def68)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
This commit is contained in:
Miss Islington (bot) 2018-07-12 07:05:43 -07:00 committed by GitHub
parent b89776fb1b
commit 4ada0cff53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Lib/test/test_time.py
View File

@ -529,19 +529,24 @@ class TimeTestCase(unittest.TestCase):
# on Windows # on Windows
self.assertLess(stop - start, 0.020) self.assertLess(stop - start, 0.020)
# bpo-33723: A busy loop of 100 ms should increase thread_time()
# by at least 15 ms
min_time = 0.015
busy_time = 0.100
# thread_time() should include CPU time spent in current thread... # thread_time() should include CPU time spent in current thread...
start = time.thread_time() start = time.thread_time()
busy_wait(0.100) busy_wait(busy_time)
stop = time.thread_time() stop = time.thread_time()
self.assertGreaterEqual(stop - start, 0.020) # machine busy? self.assertGreaterEqual(stop - start, min_time)
# ...but not in other threads # ...but not in other threads
t = threading.Thread(target=busy_wait, args=(0.100,)) t = threading.Thread(target=busy_wait, args=(busy_time,))
start = time.thread_time() start = time.thread_time()
t.start() t.start()
t.join() t.join()
stop = time.thread_time() stop = time.thread_time()
self.assertLess(stop - start, 0.020) self.assertLess(stop - start, min_time)
info = time.get_clock_info('thread_time') info = time.get_clock_info('thread_time')
self.assertTrue(info.monotonic) self.assertTrue(info.monotonic)