Issue #28131: Fix a regression in zipimport's compile_source()

zipimport should use the same optimization level as the interpreter.
This commit is contained in:
Berker Peksag 2016-09-14 08:09:48 +03:00
parent 134192630a
commit 4aa74c429c
3 changed files with 17 additions and 1 deletions

View File

@ -513,6 +513,19 @@ class UncompressedZipImportTestCase(ImportHooksBaseTestCase):
"some.data": (NOW, "some data")}
self.doTest(pyc_ext, files, TESTMOD)
def testDefaultOptimizationLevel(self):
# zipimport should use the default optimization level (#28131)
src = """if 1: # indent hack
def test(val):
assert(val)
return val\n"""
files = {TESTMOD + '.py': (NOW, src)}
self.makeZip(files)
sys.path.insert(0, TEMP_ZIP)
mod = importlib.import_module(TESTMOD)
self.assertEqual(mod.test(1), 1)
self.assertRaises(AssertionError, mod.test, False)
def testImport_WithStuff(self):
# try importing from a zipfile which contains additional
# stuff at the beginning of the file

View File

@ -10,6 +10,9 @@ Release date: TBA
Core and Builtins
-----------------
- Issue #28131: Fix a regression in zipimport's compile_source(). zipimport
should use the same optimization level as the interpreter.
- Issue #25221: Fix corrupted result from PyLong_FromLong(0) when
Python is compiled with NSMALLPOSINTS = 0.

View File

@ -1370,7 +1370,7 @@ compile_source(PyObject *pathname, PyObject *source)
}
code = Py_CompileStringObject(PyBytes_AsString(fixed_source),
pathname, Py_file_input, NULL, 1);
pathname, Py_file_input, NULL, -1);
Py_DECREF(fixed_source);
return code;