From 49d709c92143ba450ee2d3195bb3fa0505a0e88f Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Sun, 3 Jan 2010 15:05:52 +0000 Subject: [PATCH] Fix testSourceAddress to not test the host, it wasn't passing on some platforms. --- Lib/test/test_socket.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py index 055af67cca7..faa06c5a8d1 100644 --- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -1010,18 +1010,13 @@ class NetworkConnectionAttributesTest(SocketTCPTest, ThreadableTest): self.cli = socket.create_connection((HOST, self.port), timeout=30) self.assertEqual(self.cli.family, 2) - testSourcePort = _justAccept - def _testSourcePort(self): + testSourceAddress = _justAccept + def _testSourceAddress(self): self.cli = socket.create_connection((HOST, self.port), timeout=30, source_address=('', self.source_port)) self.assertEqual(self.cli.getsockname()[1], self.source_port) - - testSourceAddress = _justAccept - def _testSourceAddress(self): - self.cli = socket.create_connection( - (HOST, self.port), 30, ('127.0.0.1', self.source_port)) - self.assertEqual(self.cli.getsockname(), - ('127.0.0.1', self.source_port)) + # The port number being used is sufficient to show that the bind() + # call happened. testTimeoutDefault = _justAccept def _testTimeoutDefault(self):