traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merged revisions 79518 via svnmerge from 

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r79518 | brian.curtin | 2010-03-30 22:10:21 -0500 (Tue, 30 Mar 2010) | 2 lines

  Fix #8225. xml.etree was displaying an incorrect link when viewed in help.
........
This commit is contained in:
Brian Curtin 2010-03-31 03:19:28 +00:00
parent d6995eb582
commit 49c284c174
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/pydoc.py
View File

@ -349,7 +349,8 @@ class Doc:
'marshal', 'posix', 'signal', 'sys', 'marshal', 'posix', 'signal', 'sys',
'_thread', 'zipimport') or '_thread', 'zipimport') or
(file.startswith(basedir) and (file.startswith(basedir) and
not file.startswith(os.path.join(basedir, 'site-packages'))))): not file.startswith(os.path.join(basedir, 'site-packages')))) and
object.__name__ not in ('xml.etree')):
if docloc.startswith("http://"): if docloc.startswith("http://"):
docloc = "%s/%s" % (docloc.rstrip("/"), object.__name__) docloc = "%s/%s" % (docloc.rstrip("/"), object.__name__)
else: else:

6
Lib/test/test_pydoc.py
View File

@ -8,6 +8,7 @@ import pydoc
import inspect import inspect
import unittest import unittest
import test.support import test.support
import xml.etree
from contextlib import contextmanager from contextlib import contextmanager
from test.support import ( from test.support import (
TESTFN, forget, rmtree, EnvironmentVarGuard, reap_children) TESTFN, forget, rmtree, EnvironmentVarGuard, reap_children)
@ -265,6 +266,11 @@ class PyDocDocTest(unittest.TestCase):
print_diffs(expected_text, result) print_diffs(expected_text, result)
self.fail("outputs are not equal, see diff above") self.fail("outputs are not equal, see diff above")
def test_issue8225(self):
# Test issue8225 to ensure no doc link appears for xml.etree
result, doc_loc = get_pydoc_text(xml.etree)
self.assertEqual(doc_loc, "", "MODULE DOCS incorrectly includes a link")
def test_not_here(self): def test_not_here(self):
missing_module = "test.i_am_not_here" missing_module = "test.i_am_not_here"
result = str(run_pydoc(missing_module), 'ascii') result = str(run_pydoc(missing_module), 'ascii')