From 47f003d326f4e30a17cf9d91e384e98e7367533a Mon Sep 17 00:00:00 2001 From: Thomas Wouters Date: Tue, 7 Mar 2006 13:38:14 +0000 Subject: [PATCH] Coverity-found bug: don't use temp->next *before* checking it for NULL. Also return rather than use it again. --- Modules/_curses_panel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Modules/_curses_panel.c b/Modules/_curses_panel.c index c3f313a3348..0acf3fdee82 100644 --- a/Modules/_curses_panel.c +++ b/Modules/_curses_panel.c @@ -111,10 +111,12 @@ remove_lop(PyCursesPanelObject *po) free(temp); return; } - while (temp->next->po != po) { - if (temp->next == NULL) + while (temp->next == NULL || temp->next->po != po) { + if (temp->next == NULL) { PyErr_SetString(PyExc_RuntimeError, "remove_lop: can't find Panel Object"); + return; + } temp = temp->next; } n = temp->next->next;