traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-36522: Print all values for headers with multiple values. (GH-12681)

This commit is contained in:
Matt Houglum 2019-04-03 21:36:47 -07:00 committed by Serhiy Storchaka
parent cb0748d393
commit 461c416dd7
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Lib/http/client.py
View File

@ -320,8 +320,8 @@ class HTTPResponse(io.BufferedIOBase):
self.headers = self.msg = parse_headers(self.fp) self.headers = self.msg = parse_headers(self.fp)
if self.debuglevel > 0: if self.debuglevel > 0:
for hdr in self.headers: for hdr, val in self.headers.items():
print("header:", hdr + ":", self.headers.get(hdr)) print("header:", hdr + ":", val)
# are we using the chunked-style of transfer encoding? # are we using the chunked-style of transfer encoding?
tr_enc = self.headers.get("transfer-encoding") tr_enc = self.headers.get("transfer-encoding")

6
Lib/test/test_httplib.py
View File

@ -348,7 +348,8 @@ class HeaderTests(TestCase):
body = ( body = (
b'HTTP/1.1 200 OK\r\n' b'HTTP/1.1 200 OK\r\n'
b'First: val\r\n' b'First: val\r\n'
b'Second: val\r\n' b'Second: val1\r\n'
b'Second: val2\r\n'
) )
sock = FakeSocket(body) sock = FakeSocket(body)
resp = client.HTTPResponse(sock, debuglevel=1) resp = client.HTTPResponse(sock, debuglevel=1)
@ -357,7 +358,8 @@ class HeaderTests(TestCase):
lines = output.getvalue().splitlines() lines = output.getvalue().splitlines()
self.assertEqual(lines[0], "reply: 'HTTP/1.1 200 OK\\r\\n'") self.assertEqual(lines[0], "reply: 'HTTP/1.1 200 OK\\r\\n'")
self.assertEqual(lines[1], "header: First: val") self.assertEqual(lines[1], "header: First: val")
self.assertEqual(lines[2], "header: Second: val") self.assertEqual(lines[2], "header: Second: val1")
self.assertEqual(lines[3], "header: Second: val2")
class TransferEncodingTest(TestCase): class TransferEncodingTest(TestCase):

1
Misc/NEWS.d/next/Library/2019-04-03-20-46-47.bpo-36522.g5x3By.rst Normal file
View File

@ -0,0 +1 @@
If *debuglevel* is set to >0 in :mod:`http.client`, print all values for headers with multiple values for the same header name. Patch by Matt Houglum.