traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fail when negative values are passed to instr()

This commit is contained in:
Benjamin Peterson 2016-08-15 21:40:14 -07:00
parent 5e4aafa258
commit 432ea4ff37
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_curses.py
View File

@ -165,6 +165,8 @@ class TestCurses(unittest.TestCase):
self.assertRaises(ValueError, stdscr.getstr, -400)
self.assertRaises(ValueError, stdscr.getstr, 2, 3, -400)
self.assertRaises(ValueError, stdscr.instr, -2)
self.assertRaises(ValueError, stdscr.instr, 2, 3, -2)
def test_module_funcs(self):

4
Misc/NEWS
View File

@ -13,8 +13,8 @@ Core and Builtins
Library
-------
- In the curses module, raise an error if window.getstr() is passed a negative
value.
- In the curses module, raise an error if window.getstr() or window.instr() is
passed a negative value.
- Issue #27760: Fix possible integer overflow in binascii.b2a_qp.

8
Modules/_cursesmodule.c
View File

@ -1456,6 +1456,10 @@ PyCursesWindow_InStr(PyCursesWindowObject *self, PyObject *args)
case 1:
if (!PyArg_ParseTuple(args,"i;n", &n))
return NULL;
if (n < 0) {
PyErr_SetString(PyExc_ValueError, "'n' must be nonnegative");
return NULL;
}
rtn2 = winnstr(self->win, rtn, Py_MIN(n, 1023));
break;
case 2:
@ -1466,6 +1470,10 @@ PyCursesWindow_InStr(PyCursesWindowObject *self, PyObject *args)
case 3:
if (!PyArg_ParseTuple(args, "iii;y,x,n", &y, &x, &n))
return NULL;
if (n < 0) {
PyErr_SetString(PyExc_ValueError, "'n' must be nonnegative");
return NULL;
}
rtn2 = mvwinnstr(self->win, y, x, rtn, Py_MIN(n,1023));
break;
default: