From 42c83afd14e1c7270124e581e42163ff5ef98ed8 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Fri, 29 Sep 2000 04:03:10 +0000 Subject: [PATCH] The 2.0b2 change to write .pyc files in exclusive mode (if possible) unintentionally caused them to get written in text mode under Windows. As a result, when .pyc files were later read-- in binary mode --the magic number was always wrong (note that .pyc magic numbers deliberately include \r and \n characters, so this was "good" breakage, 100% across all .pyc files, not random corruption in a subset). Fixed that. --- Python/import.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Python/import.c b/Python/import.c index 533f85e0fd7..9ecd38de978 100644 --- a/Python/import.c +++ b/Python/import.c @@ -646,7 +646,12 @@ open_exclusive(char *filename) */ int fd; (void) unlink(filename); - fd = open(filename, O_EXCL|O_CREAT|O_WRONLY|O_TRUNC, 0666); + fd = open(filename, O_EXCL|O_CREAT|O_WRONLY|O_TRUNC +#ifdef O_BINARY + |O_BINARY /* necessary for Windows */ +#endif + + , 0666); if (fd < 0) return NULL; return fdopen(fd, "wb");