build_ext: correctly parse the link_objects user option (closes #1703178)

Patch by Valerie Lambert.
This commit is contained in:
Benjamin Peterson 2016-09-28 23:13:58 -07:00
parent c49b4d8ef3
commit 4254e8c548
3 changed files with 11 additions and 0 deletions

View File

@ -166,6 +166,7 @@ class build_ext(Command):
self.include_dirs.append(plat_py_include) self.include_dirs.append(plat_py_include)
self.ensure_string_list('libraries') self.ensure_string_list('libraries')
self.ensure_string_list('link_objects')
# Life is easier if we're not forever checking for None, so # Life is easier if we're not forever checking for None, so
# simplify these options to empty lists if unset # simplify these options to empty lists if unset

View File

@ -195,6 +195,13 @@ class BuildExtTestCase(TempdirManager,
cmd.finalize_options() cmd.finalize_options()
self.assertEqual(cmd.rpath, ['one', 'two']) self.assertEqual(cmd.rpath, ['one', 'two'])
# make sure cmd.link_objects is turned into a list
# if it's a string
cmd = build_ext(dist)
cmd.link_objects = 'one two,three'
cmd.finalize_options()
self.assertEqual(cmd.link_objects, ['one', 'two', 'three'])
# XXX more tests to perform for win32 # XXX more tests to perform for win32
# make sure define is turned into 2-tuples # make sure define is turned into 2-tuples

View File

@ -83,6 +83,9 @@ Core and Builtins
Library Library
------- -------
- Issue #1703178: Fix the ability to pass the --link-objects option to the
distutils build_ext command.
- Issue #28253: Fixed calendar functions for extreme months: 0001-01 - Issue #28253: Fixed calendar functions for extreme months: 0001-01
and 9999-12. and 9999-12.