From 40188782dd9cf3495293d8fe07070d4c642389fd Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Sat, 3 Jan 2009 09:24:18 +0000 Subject: [PATCH] Fractions.from_float() no longer loses precision with large integer inputs. --- Lib/fractions.py | 2 +- Lib/test/test_fractions.py | 2 ++ Misc/NEWS | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Lib/fractions.py b/Lib/fractions.py index 4adb184a9ee..446ad8ea827 100755 --- a/Lib/fractions.py +++ b/Lib/fractions.py @@ -111,7 +111,7 @@ class Fraction(Rational): """ if isinstance(f, numbers.Integral): - f = float(f) + return cls(f) elif not isinstance(f, float): raise TypeError("%s.from_float() only takes floats, not %r (%s)" % (cls.__name__, f, type(f).__name__)) diff --git a/Lib/test/test_fractions.py b/Lib/test/test_fractions.py index 979fef75cdf..a6c3c32cb09 100644 --- a/Lib/test/test_fractions.py +++ b/Lib/test/test_fractions.py @@ -139,6 +139,8 @@ class FractionTest(unittest.TestCase): def testFromFloat(self): self.assertRaises(TypeError, F.from_float, 3+4j) self.assertEquals((10, 1), _components(F.from_float(10))) + bigint = 1234567890123456789 + self.assertEquals((bigint, 1), _components(F.from_float(bigint))) self.assertEquals((0, 1), _components(F.from_float(-0.0))) self.assertEquals((10, 1), _components(F.from_float(10.0))) self.assertEquals((-5, 2), _components(F.from_float(-2.5))) diff --git a/Misc/NEWS b/Misc/NEWS index 02e5085ca38..2606ac1cef5 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -56,6 +56,9 @@ Core and Builtins Library ------- +- Fractions.from_float() no longer loses precision for integers to big to + cast as floats. + - Issue 4790: The nsmallest() and nlargest() functions in the heapq module did unnecessary work in the common case where no key function was specified.