Fix buglet in sliceobjects, they were not returning Py_NotImplemented when

compared against something other than sliceobjects.
This commit is contained in:
Thomas Wouters 2007-08-28 23:07:26 +00:00
parent ed03b4121e
commit 3e57b52bb8
2 changed files with 8 additions and 0 deletions

View File

@ -26,6 +26,9 @@ class SliceTest(unittest.TestCase):
s3 = slice(1, 2, 4)
self.assertEqual(s1, s2)
self.assertNotEqual(s1, s3)
self.assertNotEqual(s1, None)
self.assertNotEqual(s1, (1, 2, 3))
self.assertNotEqual(s1, "")
class Exc(Exception):
pass

View File

@ -286,6 +286,11 @@ slice_richcompare(PyObject *v, PyObject *w, int op)
PyObject *t2;
PyObject *res;
if (!PySlice_Check(v) || !PySlice_Check(w)) {
Py_INCREF(Py_NotImplemented);
return Py_NotImplemented;
}
if (v == w) {
/* XXX Do we really need this shortcut?
There's a unit test for it, but is that fair? */