traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-38708: email: Fix a potential IndexError when parsing Message-ID (GH-17504) 

Fix a potential IndexError when passing an empty value to the message-id
parser. Instead, HeaderParseError should be raised.
This commit is contained in:
Abhilash Raj 2019-12-08 17:37:34 -08:00 committed by GitHub
parent 68157da8b4
commit 3ae4ea1931
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/email/_header_value_parser.py
View File

@ -2047,7 +2047,7 @@ def get_msg_id(value):
no-fold-literal = "[" *dtext "]" no-fold-literal = "[" *dtext "]"
""" """
msg_id = MsgID() msg_id = MsgID()
if value[0] in CFWS_LEADER: if value and value[0] in CFWS_LEADER:
token, value = get_cfws(value) token, value = get_cfws(value)
msg_id.append(token) msg_id.append(token)
if not value or value[0] != '<': if not value or value[0] != '<':

6
Lib/test/test_email/test__header_value_parser.py
View File

@ -2583,6 +2583,11 @@ class TestParser(TestParserMixin, TestEmailBase):
# get_msg_id # get_msg_id
def test_get_msg_id_empty(self):
# bpo-38708: Test that HeaderParseError is raised and not IndexError.
with self.assertRaises(errors.HeaderParseError):
parser.get_msg_id('')
def test_get_msg_id_valid(self): def test_get_msg_id_valid(self):
msg_id = self._test_get_x( msg_id = self._test_get_x(
parser.get_msg_id, parser.get_msg_id,
@ -2694,6 +2699,7 @@ class TestParser(TestParserMixin, TestEmailBase):
self.assertEqual(msg_id.token_type, 'msg-id') self.assertEqual(msg_id.token_type, 'msg-id')
@parameterize @parameterize
class Test_parse_mime_parameters(TestParserMixin, TestEmailBase): class Test_parse_mime_parameters(TestParserMixin, TestEmailBase):

1
Misc/NEWS.d/next/Library/2019-12-07-22-25-39.bpo-38708.rZTUfk.rst Normal file
View File

@ -0,0 +1 @@
Fix a potential IndexError in email parser when parsing an empty msg-id.