bpo-38708: email: Fix a potential IndexError when parsing Message-ID (GH-17504)
Fix a potential IndexError when passing an empty value to the message-id parser. Instead, HeaderParseError should be raised.
This commit is contained in:
parent
68157da8b4
commit
3ae4ea1931
|
@ -2047,7 +2047,7 @@ def get_msg_id(value):
|
|||
no-fold-literal = "[" *dtext "]"
|
||||
"""
|
||||
msg_id = MsgID()
|
||||
if value[0] in CFWS_LEADER:
|
||||
if value and value[0] in CFWS_LEADER:
|
||||
token, value = get_cfws(value)
|
||||
msg_id.append(token)
|
||||
if not value or value[0] != '<':
|
||||
|
|
|
@ -2583,6 +2583,11 @@ class TestParser(TestParserMixin, TestEmailBase):
|
|||
|
||||
# get_msg_id
|
||||
|
||||
def test_get_msg_id_empty(self):
|
||||
# bpo-38708: Test that HeaderParseError is raised and not IndexError.
|
||||
with self.assertRaises(errors.HeaderParseError):
|
||||
parser.get_msg_id('')
|
||||
|
||||
def test_get_msg_id_valid(self):
|
||||
msg_id = self._test_get_x(
|
||||
parser.get_msg_id,
|
||||
|
@ -2694,6 +2699,7 @@ class TestParser(TestParserMixin, TestEmailBase):
|
|||
self.assertEqual(msg_id.token_type, 'msg-id')
|
||||
|
||||
|
||||
|
||||
@parameterize
|
||||
class Test_parse_mime_parameters(TestParserMixin, TestEmailBase):
|
||||
|
||||
|
|
|
@ -0,0 +1 @@
|
|||
Fix a potential IndexError in email parser when parsing an empty msg-id.
|
Loading…
Reference in New Issue