From 61b787e6dd00b1e6e24a12e2d5aa6e9fd1352663 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Mon, 7 Nov 2011 08:53:03 +0000 Subject: [PATCH] Closes #13661: Check added for type of logger name. --- Lib/logging/__init__.py | 2 ++ Lib/test/test_logging.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py index de5392beca8..bea290eff1a 100644 --- a/Lib/logging/__init__.py +++ b/Lib/logging/__init__.py @@ -1094,6 +1094,8 @@ class Manager(object): placeholder to now point to the logger. """ rv = None + if not isinstance(name, str): + raise ValueError('A logger name must be a string') _acquireLock() try: if name in self.loggerDict: diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py index 90d293e3abe..a022680d4d2 100644 --- a/Lib/test/test_logging.py +++ b/Lib/test/test_logging.py @@ -293,6 +293,8 @@ class BuiltinLevelsTest(BaseTest): ('INF.BADPARENT', 'INFO', '4'), ]) + def test_invalid_name(self): + self.assertRaises(ValueError, logging.getLogger, any) class BasicFilterTest(BaseTest):