From 370d04d1dcca50a52d59f40aff4d11434f71df6b Mon Sep 17 00:00:00 2001 From: Xiang Zhang Date: Tue, 23 Jan 2018 22:50:50 +0800 Subject: [PATCH] bpo-32618: Fix test_mutatingdecodehandler not testing test.mutating (#5269) * bpo-32618: Fix test_mutatingdecodehandler not testing test.mutating It should test both test.replacing and test.mutating instead of test test.replacing twice. --- Lib/test/test_codeccallbacks.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_codeccallbacks.py b/Lib/test/test_codeccallbacks.py index 6a3e9932656..0c066e633fa 100644 --- a/Lib/test/test_codeccallbacks.py +++ b/Lib/test/test_codeccallbacks.py @@ -1032,7 +1032,7 @@ class CodecCallbackTest(unittest.TestCase): def mutating(exc): if isinstance(exc, UnicodeDecodeError): - exc.object[:] = b"" + exc.object = b"" return ("\u4242", 0) else: raise TypeError("don't know how to handle %r" % exc) @@ -1042,8 +1042,7 @@ class CodecCallbackTest(unittest.TestCase): with test.support.check_warnings(): # unicode-internal has been deprecated for (encoding, data) in baddata: - with self.assertRaises(TypeError): - data.decode(encoding, "test.replacing") + self.assertEqual(data.decode(encoding, "test.mutating"), "\u4242") def test_fake_error_class(self): handlers = [