From 352bf0d7ee71d401bc2d001b27c3d71c1074fc98 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Mon, 31 Jul 2006 02:40:23 +0000 Subject: [PATCH] ZipFile.close(): Killed one of the struct.pack deprecation warnings on Win32. Also added an XXX about the line: pos3 = self.fp.tell() `pos3` is never referenced, and I have no idea what the code intended to do instead. --- Lib/zipfile.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Lib/zipfile.py b/Lib/zipfile.py index 865267a7ccc..2819f1bd148 100644 --- a/Lib/zipfile.py +++ b/Lib/zipfile.py @@ -708,9 +708,10 @@ class ZipFile: stringEndArchive64Locator, 0, pos2, 1) self.fp.write(zip64locrec) + # XXX Why is `pos3` computed next? It's never referenced. pos3 = self.fp.tell() endrec = struct.pack(structEndArchive, stringEndArchive, - 0, 0, count, count, pos2 - pos1, 0xffffffff, 0) # -1, 0) + 0, 0, count, count, pos2 - pos1, -1, 0) self.fp.write(endrec) else: