traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

promote some shifts to unsigned, so as not to invoke undefined behavior

This commit is contained in:
Benjamin Peterson 2016-09-06 20:40:04 -07:00
parent 4a757609d1
commit 33d2a492d0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Objects/unicodeobject.c
View File

@ -4944,7 +4944,7 @@ PyUnicode_DecodeUTF32Stateful(const char *s,
mark is skipped, in all other modes, it is copied to the output
stream as-is (giving a ZWNBSP character). */
if (bo == 0 && size >= 4) {
Py_UCS4 bom = (q[3] << 24) | (q[2] << 16) | (q[1] << 8) | q[0];
Py_UCS4 bom = ((unsigned int)q[3] << 24) | (q[2] << 16) | (q[1] << 8) | q[0];
if (bom == 0x0000FEFF) {
bo = -1;
q += 4;
@ -4986,7 +4986,7 @@ PyUnicode_DecodeUTF32Stateful(const char *s,
Py_ssize_t pos = writer.pos;
if (le) {
do {
ch = (q[3] << 24) | (q[2] << 16) | (q[1] << 8) | q[0];
ch = ((unsigned int)q[3] << 24) | (q[2] << 16) | (q[1] << 8) | q[0];
if (ch > maxch)
break;
if (kind != PyUnicode_1BYTE_KIND &&
@ -4998,7 +4998,7 @@ PyUnicode_DecodeUTF32Stateful(const char *s,
}
else {
do {
ch = (q[0] << 24) | (q[1] << 16) | (q[2] << 8) | q[3];
ch = ((unsigned int)q[0] << 24) | (q[1] << 16) | (q[2] << 8) | q[3];
if (ch > maxch)
break;
if (kind != PyUnicode_1BYTE_KIND &&