From 2da91c375b095a452dd1e81962983e89e3fd0d07 Mon Sep 17 00:00:00 2001
From: Facundo Batista <facundobatista@gmail.com>
Date: Sat, 21 Jun 2008 17:43:56 +0000
Subject: [PATCH] Fixed issue #2888. Now the behaviour of pprint when working
 with nested structures follows the common sense (and works like in 2.5 and
 3.0).

---
 Doc/library/pprint.rst  |  2 +-
 Lib/pprint.py           |  2 +-
 Lib/test/test_pprint.py | 11 +++++++++++
 Misc/NEWS               |  4 ++++
 4 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/Doc/library/pprint.rst b/Doc/library/pprint.rst
index c0bedf5d5b6..7bcb3f1856b 100644
--- a/Doc/library/pprint.rst
+++ b/Doc/library/pprint.rst
@@ -56,7 +56,7 @@ The :mod:`pprint` module defines one class:
       >>> stuff.insert(0, stuff[:])
       >>> pp = pprint.PrettyPrinter(indent=4)
       >>> pp.pprint(stuff)
-      [   [   'spam', 'eggs', 'lumberjack', 'knights', 'ni'],
+      [   ['spam', 'eggs', 'lumberjack', 'knights', 'ni'],
           'spam',
           'eggs',
           'lumberjack',
diff --git a/Lib/pprint.py b/Lib/pprint.py
index 93d850aca18..c48465b8d58 100644
--- a/Lib/pprint.py
+++ b/Lib/pprint.py
@@ -194,7 +194,7 @@ class PrettyPrinter:
             else:
                 write('(')
                 endchar = ')'
-            if self._indent_per_level > 1:
+            if self._indent_per_level > 1 and sepLines:
                 write((self._indent_per_level - 1) * ' ')
             if length:
                 context[objid] = 1
diff --git a/Lib/test/test_pprint.py b/Lib/test/test_pprint.py
index 4d7a3ed1472..439f605e63b 100644
--- a/Lib/test/test_pprint.py
+++ b/Lib/test/test_pprint.py
@@ -170,6 +170,17 @@ class QueryTestCase(unittest.TestCase):
         for type in [list, list2]:
             self.assertEqual(pprint.pformat(type(o), indent=4), exp)
 
+    def test_nested_indentations(self):
+        o1 = list(range(10))
+        o2 = dict(first=1, second=2, third=3)
+        o = [o1, o2]
+        expected = """\
+[   [0, 1, 2, 3, 4, 5, 6, 7, 8, 9],
+    {   'first': 1,
+        'second': 2,
+        'third': 3}]"""
+        self.assertEqual(pprint.pformat(o, indent=4, width=42), expected)
+
     def test_sorted_dict(self):
         # Starting in Python 2.5, pprint sorts dict displays by key regardless
         # of how small the dictionary may be.
diff --git a/Misc/NEWS b/Misc/NEWS
index 2825198169d..c5dfe73065f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -108,6 +108,10 @@ Extension Modules
 Library
 -------
 
+- Issue #2888: Fixed the behaviour of pprint when working with nested
+  structures, to match the behaviour of 2.5 and 3.0 (now follows the common
+  sense).
+
 - Issue #3136: fileConfig()'s disabling of old loggers is now conditional via
   an optional disable_existing_loggers parameter, but the default value is
   such that the old behaviour is preserved. Thanks to Leandro Lucarella for