Issue #27445: Don't pass str(_charset) to MIMEText.set_payload()

Patch by Claude Paroz.
This commit is contained in:
Berker Peksag 2016-09-08 19:40:30 +03:00
parent 82733fac8d
commit 2b2a9be913
3 changed files with 8 additions and 4 deletions

View File

@ -35,10 +35,8 @@ class MIMEText(MIMENonMultipart):
_charset = 'us-ascii'
except UnicodeEncodeError:
_charset = 'utf-8'
if isinstance(_charset, Charset):
_charset = str(_charset)
MIMENonMultipart.__init__(self, 'text', _subtype,
**{'charset': _charset})
**{'charset': str(_charset)})
self.set_payload(_text, _charset)

View File

@ -1652,9 +1652,12 @@ class TestMIMEText(unittest.TestCase):
eq(msg.get_charset().input_charset, 'us-ascii')
eq(msg['content-type'], 'text/plain; charset="us-ascii"')
# Also accept a Charset instance
msg = MIMEText('hello there', _charset=Charset('utf-8'))
charset = Charset('utf-8')
charset.body_encoding = None
msg = MIMEText('hello there', _charset=charset)
eq(msg.get_charset().input_charset, 'utf-8')
eq(msg['content-type'], 'text/plain; charset="utf-8"')
eq(msg.get_payload(), 'hello there')
def test_7bit_input(self):
eq = self.assertEqual

View File

@ -60,6 +60,9 @@ Core and Builtins
Library
-------
- Issue #27445: Don't pass str(_charset) to MIMEText.set_payload().
Patch by Claude Paroz.
- lib2to3.pgen3.driver.load_grammar() now creates a stable cache file
between runs given the same Grammar.txt input regardless of the hash
randomization setting.