Issue #22421 - Secure pydoc server run. Bind it to localhost instead of all interfaces.
This commit is contained in:
parent
7d0b8f95e7
commit
2a42a0bff3
|
@ -2168,8 +2168,8 @@ def _start_server(urlhandler, port):
|
|||
class DocServer(http.server.HTTPServer):
|
||||
|
||||
def __init__(self, port, callback):
|
||||
self.host = (sys.platform == 'mac') and '127.0.0.1' or 'localhost'
|
||||
self.address = ('', port)
|
||||
self.host = 'localhost'
|
||||
self.address = (self.host, port)
|
||||
self.callback = callback
|
||||
self.base.__init__(self, self.address, self.handler)
|
||||
self.quit = False
|
||||
|
|
|
@ -557,6 +557,8 @@ class PydocServerTest(unittest.TestCase):
|
|||
return text
|
||||
|
||||
serverthread = pydoc._start_server(my_url_handler, port=0)
|
||||
self.assertIn('localhost', serverthread.docserver.address)
|
||||
|
||||
starttime = time.time()
|
||||
timeout = 1 #seconds
|
||||
|
||||
|
|
Loading…
Reference in New Issue