From 24f67d568cf878f53c647356aa4e446f7ae9de61 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Wed, 17 Jan 2001 23:43:43 +0000 Subject: [PATCH] Fix a leak in instance_coerce(). This was introduced by Neil's earlier coercion changes, not by rich comparisons. When a coercion function returns 1 (meaning it cannot do it), it should not INCREF the arguments. When no __coerce__() method was found, instance_coerce() originally returned 0, pretending it did it. Neil changed the return value to 1, more accurately reflecting that it didn't do anything, but forgot to take out the two INCREF calls. --- Objects/classobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Objects/classobject.c b/Objects/classobject.c index 7f76d6ed5ab..5e987ff6b8b 100644 --- a/Objects/classobject.c +++ b/Objects/classobject.c @@ -1289,8 +1289,6 @@ instance_coerce(PyObject **pv, PyObject **pw) if (coercefunc == NULL) { /* No __coerce__ method */ PyErr_Clear(); - Py_INCREF(v); - Py_INCREF(w); return 1; } /* Has __coerce__ method: call it */