From 1f34729f42c0f386c5c95580ba736fd9758cf9a2 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Sun, 21 Jul 2013 02:12:35 +0200 Subject: [PATCH] Check return value of lseek() in _Py_DisplaySourceLine(). Also use portable SEEK_SET instead of 0. CID 1040639 --- Python/traceback.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Python/traceback.c b/Python/traceback.c index c37aab0a9c1..1f611ba1d51 100644 --- a/Python/traceback.c +++ b/Python/traceback.c @@ -262,7 +262,13 @@ _Py_DisplaySourceLine(PyObject *f, PyObject *filename, int lineno, int indent) } found_encoding = PyTokenizer_FindEncodingFilename(fd, filename); encoding = (found_encoding != NULL) ? found_encoding : "utf-8"; - lseek(fd, 0, 0); /* Reset position */ + /* Reset position */ + if (lseek(fd, 0, SEEK_SET) == (off_t)-1) { + Py_DECREF(io); + Py_DECREF(binary); + PyMem_FREE(found_encoding); + return PyErr_SetFromErrnoWithFilenameObject(PyExc_IOError, filename); + } fob = _PyObject_CallMethodId(io, &PyId_TextIOWrapper, "Os", binary, encoding); Py_DECREF(io); Py_DECREF(binary);