traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rearrange methodcaller_new so that the main error case does not cause uninitialized memory usage (closes #27783)

This commit is contained in:
Benjamin Peterson 2016-08-16 23:35:35 -07:00
parent 3a27b0857e
commit 1f0e7c9933
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS
View File

@ -29,6 +29,8 @@ Core and Builtins
Library Library
------- -------
- Issue #27783: Fix possible usage of uninitialized memory in operator.methodcaller.
- Issue #27774: Fix possible Py_DECREF on unowned object in _sre. - Issue #27774: Fix possible Py_DECREF on unowned object in _sre.
- Issue #27760: Fix possible integer overflow in binascii.b2a_qp. - Issue #27760: Fix possible integer overflow in binascii.b2a_qp.

15
Modules/operator.c
View File

@ -776,7 +776,7 @@ static PyObject *
methodcaller_new(PyTypeObject *type, PyObject *args, PyObject *kwds) methodcaller_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
{ {
methodcallerobject *mc; methodcallerobject *mc;
PyObject *name, *newargs; PyObject *name;
if (PyTuple_GET_SIZE(args) < 1) { if (PyTuple_GET_SIZE(args) < 1) {
PyErr_SetString(PyExc_TypeError, "methodcaller needs at least " PyErr_SetString(PyExc_TypeError, "methodcaller needs at least "
@ -789,13 +789,6 @@ methodcaller_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
if (mc == NULL) if (mc == NULL)
return NULL; return NULL;
newargs = PyTuple_GetSlice(args, 1, PyTuple_GET_SIZE(args));
if (newargs == NULL) {
Py_DECREF(mc);
return NULL;
}
mc->args = newargs;
name = PyTuple_GET_ITEM(args, 0); name = PyTuple_GET_ITEM(args, 0);
Py_INCREF(name); Py_INCREF(name);
mc->name = name; mc->name = name;
@ -803,6 +796,12 @@ methodcaller_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
Py_XINCREF(kwds); Py_XINCREF(kwds);
mc->kwds = kwds; mc->kwds = kwds;
mc->args = PyTuple_GetSlice(args, 1, PyTuple_GET_SIZE(args));
if (mc->args == NULL) {
Py_DECREF(mc);
return NULL;
}
PyObject_GC_Track(mc); PyObject_GC_Track(mc);
return (PyObject *)mc; return (PyObject *)mc;
} }