traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

it suffices to check for PY_SSIZE_T_MAX overflow (#22643)

This commit is contained in:
Benjamin Peterson 2014-10-15 12:17:21 -04:00
parent c0e64f5027
commit 1e211ff10d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Objects/unicodeobject.c
View File

@ -9484,12 +9484,11 @@ case_operation(PyObject *self,
kind = PyUnicode_KIND(self); kind = PyUnicode_KIND(self);
data = PyUnicode_DATA(self); data = PyUnicode_DATA(self);
length = PyUnicode_GET_LENGTH(self); length = PyUnicode_GET_LENGTH(self);
if (length > PY_SSIZE_T_MAX / 3 || if (length > PY_SSIZE_T_MAX / (3 * sizeof(Py_UCS4))) {
length > PY_SIZE_MAX / (3 * sizeof(Py_UCS4))) {
PyErr_SetString(PyExc_OverflowError, "string is too long"); PyErr_SetString(PyExc_OverflowError, "string is too long");
return NULL; return NULL;
} }
tmp = PyMem_MALLOC(sizeof(Py_UCS4) * 3 * (size_t)length); tmp = PyMem_MALLOC(sizeof(Py_UCS4) * 3 * length);
if (tmp == NULL) if (tmp == NULL)
return PyErr_NoMemory(); return PyErr_NoMemory();
newlength = perform(kind, data, length, tmp, &maxchar); newlength = perform(kind, data, length, tmp, &maxchar);