Issue #28605: Fix the help and What's New entry for --with-optimizations.

This commit is contained in:
Brett Cannon 2016-11-03 16:20:00 -07:00
parent f905063ee3
commit 1d8f755e67
3 changed files with 6 additions and 6 deletions

View File

@ -1176,7 +1176,7 @@ Build and C API Changes
with only about 16 tests failures. See the Android meta-issue :issue:`26865`. with only about 16 tests failures. See the Android meta-issue :issue:`26865`.
* The ``--with-optimizations`` configure flag has been added. Turning it on * The ``--with-optimizations`` configure flag has been added. Turning it on
will activate LTO and PGO build support (when available). will activate expensive optimizations like PGO.
(Original patch by Alecsandru Patrascu of Intel in :issue:`26539`.) (Original patch by Alecsandru Patrascu of Intel in :issue:`26539`.)
* New :c:func:`Py_FinalizeEx` API which indicates if flushing buffered data * New :c:func:`Py_FinalizeEx` API which indicates if flushing buffered data

6
configure vendored
View File

@ -1499,8 +1499,8 @@ Optional Packages:
compiler compiler
--with-suffix=.exe set executable suffix --with-suffix=.exe set executable suffix
--with-pydebug build with Py_DEBUG defined --with-pydebug build with Py_DEBUG defined
--with-optimizations Enable expensive optimizations (PGO, maybe LTO, --with-optimizations Enable expensive optimizations (PGO, etc). Disabled
etc). Disabled by default. by default.
--with-lto Enable Link Time Optimization in PGO builds. --with-lto Enable Link Time Optimization in PGO builds.
Disabled by default. Disabled by default.
--with-hash-algorithm=[fnv|siphash24] --with-hash-algorithm=[fnv|siphash24]
@ -6548,7 +6548,7 @@ fi
if test "$Py_OPT" = 'true' ; then if test "$Py_OPT" = 'true' ; then
# Intentionally not forcing Py_LTO='true' here. Too many toolchains do not # Intentionally not forcing Py_LTO='true' here. Too many toolchains do not
# compile working code using it and both test_distutils and test_gdb are # compile working code using it and both test_distutils and test_gdb are
# broken when you do managed to get a toolchain that works with it. People # broken when you do manage to get a toolchain that works with it. People
# who want LTO need to use --with-lto themselves. # who want LTO need to use --with-lto themselves.
DEF_MAKE_ALL_RULE="profile-opt" DEF_MAKE_ALL_RULE="profile-opt"
REQUIRE_PGO="yes" REQUIRE_PGO="yes"

View File

@ -1282,7 +1282,7 @@ AC_SUBST(DEF_MAKE_ALL_RULE)
AC_SUBST(DEF_MAKE_RULE) AC_SUBST(DEF_MAKE_RULE)
Py_OPT='false' Py_OPT='false'
AC_MSG_CHECKING(for --with-optimizations) AC_MSG_CHECKING(for --with-optimizations)
AC_ARG_WITH(optimizations, AS_HELP_STRING([--with-optimizations], [Enable expensive optimizations (PGO, maybe LTO, etc). Disabled by default.]), AC_ARG_WITH(optimizations, AS_HELP_STRING([--with-optimizations], [Enable expensive optimizations (PGO, etc). Disabled by default.]),
[ [
if test "$withval" != no if test "$withval" != no
then then
@ -1296,7 +1296,7 @@ fi],
if test "$Py_OPT" = 'true' ; then if test "$Py_OPT" = 'true' ; then
# Intentionally not forcing Py_LTO='true' here. Too many toolchains do not # Intentionally not forcing Py_LTO='true' here. Too many toolchains do not
# compile working code using it and both test_distutils and test_gdb are # compile working code using it and both test_distutils and test_gdb are
# broken when you do managed to get a toolchain that works with it. People # broken when you do manage to get a toolchain that works with it. People
# who want LTO need to use --with-lto themselves. # who want LTO need to use --with-lto themselves.
DEF_MAKE_ALL_RULE="profile-opt" DEF_MAKE_ALL_RULE="profile-opt"
REQUIRE_PGO="yes" REQUIRE_PGO="yes"