traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

_winconsoleio: Fix memory leak (#2485) 

Fix memory leak when _winconsoleio tries to open a non-console file:
free the name buffer.
This commit is contained in:
Victor Stinner 2017-06-29 10:53:34 +02:00 committed by GitHub
parent b78fbaaeab
commit 1d56ed5210
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Modules/_io/winconsoleio.c
View File

@ -317,6 +317,7 @@ _io__WindowsConsoleIO___init___impl(winconsoleio *self, PyObject *nameobj,
if (name == NULL)
return -1;
if (console_type == '\0') {
PyMem_Free(name);
PyErr_SetString(PyExc_ValueError,
"Cannot open non-console file");
return -1;
@ -400,7 +401,7 @@ _io__WindowsConsoleIO___init___impl(winconsoleio *self, PyObject *nameobj,
PyErr_SetString(PyExc_ValueError,
"Cannot open non-console file");
goto error;
}
}
if (self->writable && console_type != 'w') {
PyErr_SetString(PyExc_ValueError,
"Cannot open console input buffer for writing");
@ -428,8 +429,7 @@ error:
internal_close(self);
done:
if (name)
PyMem_Free(name);
PyMem_Free(name);
return ret;
}