Issue #17149: merge fix from 3.3.

This commit is contained in:
Mark Dickinson 2013-02-10 14:17:20 +00:00
commit 1b901baee5
3 changed files with 19 additions and 2 deletions

View File

@ -450,9 +450,9 @@ class Random(_random.Random):
u3 = random()
if u3 > 0.5:
theta = (mu % TWOPI) + _acos(f)
theta = (mu + _acos(f)) % TWOPI
else:
theta = (mu % TWOPI) - _acos(f)
theta = (mu - _acos(f)) % TWOPI
return theta

View File

@ -512,6 +512,20 @@ class TestDistributions(unittest.TestCase):
self.assertAlmostEqual(s1/N, mu, places=2)
self.assertAlmostEqual(s2/(N-1), sigmasqrd, places=2)
def test_von_mises_range(self):
# Issue 17149: von mises variates were not consistently in the
# range [0, 2*PI].
g = random.Random()
N = 100
for mu in 0.0, 0.1, 3.1, 6.2:
for kappa in 0.0, 2.3, 500.0:
for _ in range(N):
sample = g.vonmisesvariate(mu, kappa)
self.assertTrue(
0 <= sample <= random.TWOPI,
msg=("vonmisesvariate({}, {}) produced a result {} out"
" of range [0, 2*pi]").format(mu, kappa, sample))
class TestModule(unittest.TestCase):
def testMagicConstants(self):
self.assertAlmostEqual(random.NV_MAGICCONST, 1.71552776992141)

View File

@ -244,6 +244,9 @@ Core and Builtins
Library
-------
- Issue #17149: Fix random.vonmisesvariate to always return results in
[0, 2*math.pi].
- Issue #1470548: XMLGenerator now works with binary output streams.
- Issue #6975: os.path.realpath() now correctly resolves multiple nested