#1433694: minidom's .normalize() failed to set .nextSibling for last element.

Fix by Malte Helmert
This commit is contained in:
Andrew M. Kuchling 2008-02-23 17:10:46 +00:00
parent 8887e54867
commit 19aff0c90a
3 changed files with 11 additions and 0 deletions

View File

@ -791,6 +791,14 @@ class MinidomTest(unittest.TestCase):
"testNormalize -- single empty node removed")
doc.unlink()
def testBug1433694(self):
doc = parseString("<o><i/>t</o>")
node = doc.documentElement
node.childNodes[1].nodeValue = ""
node.normalize()
self.confirm(node.childNodes[-1].nextSibling == None,
"Final child's .nextSibling should be None")
def testSiblings(self):
doc = parseString("<doc><?pi?>text?<elm/></doc>")
root = doc.documentElement

View File

@ -203,6 +203,8 @@ class Node(xml.dom.Node):
L.append(child)
if child.nodeType == Node.ELEMENT_NODE:
child.normalize()
if L:
L[-1].nextSibling = None
self.childNodes[:] = L
def cloneNode(self, deep):

View File

@ -274,6 +274,7 @@ Shane Hathaway
Rycharde Hawkes
Jochen Hayek
Thomas Heller
Malte Helmert
Lance Finn Helsten
Jonathan Hendry
James Henstridge