Issue #23881: Only use entry-values with gdb 7.4 in tests.

Fixes a regression in issue #22765.  Patch by Vinson Lee.
This commit is contained in:
Serhiy Storchaka 2015-02-06 08:35:20 +02:00
parent 50afcc09ac
commit 17d337bc7a
1 changed files with 10 additions and 8 deletions

View File

@ -124,14 +124,6 @@ class DebuggerTests(unittest.TestCase):
commands = ['set breakpoint pending yes',
'break %s' % breakpoint,
# GDB as of 7.4 (?) onwards can distinguish between the
# value of a variable at entry vs current value:
# http://sourceware.org/gdb/onlinedocs/gdb/Variables.html
# which leads to the selftests failing with errors like this:
# AssertionError: 'v@entry=()' != '()'
# Disable this:
'set print entry-values no',
# The tests assume that the first frame of printed
# backtrace will not contain program counter,
# that is however not guaranteed by gdb
@ -143,6 +135,16 @@ class DebuggerTests(unittest.TestCase):
'set print address off',
'run']
# GDB as of 7.4 onwards can distinguish between the
# value of a variable at entry vs current value:
# http://sourceware.org/gdb/onlinedocs/gdb/Variables.html
# which leads to the selftests failing with errors like this:
# AssertionError: 'v@entry=()' != '()'
# Disable this:
if (gdb_major_version, gdb_minor_version) >= (7, 4):
commands += ['set print entry-values no']
if cmds_after_breakpoint:
commands += cmds_after_breakpoint
else: