traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Added comment about the MSVC-specific kludge.

This commit is contained in:
Greg Ward 2000-05-09 01:50:41 +00:00
parent 5879a533f1
commit 1500374667
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Lib/distutils/command/build_ext.py
View File

@ -308,6 +308,16 @@ class build_ext (Command):
rpath = build_info.get ('rpath') rpath = build_info.get ('rpath')
extra_args = build_info.get ('extra_link_args') or [] extra_args = build_info.get ('extra_link_args') or []
# XXX this is a kludge! Knowledge of specific compilers or
# platforms really doesn't belong here; in an ideal world, the
# CCompiler interface would provide access to everything in a
# compiler/linker system needs to build Python extensions, and
# we would just do everything nicely and cleanly through that
# interface. However, this is a not an ideal world and the
# CCompiler interface doesn't handle absolutely everything.
# Thus, kludges like this slip in occasionally. (This is no
# excuse for committing more platform- and compiler-specific
# kludges; they are to be avoided if possible!)
if self.compiler.compiler_type == 'msvc': if self.compiler.compiler_type == 'msvc':
def_file = build_info.get ('def_file') def_file = build_info.get ('def_file')
if def_file is None: if def_file is None: