traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

close file explicitly

This commit is contained in:
Benjamin Peterson 2009-05-10 01:38:02 +00:00
parent ceea163e7c
commit 14c7bc2ad2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Lib/gettext.py
View File

@ -467,7 +467,6 @@ def translation(domain, localedir=None, languages=None,
if fallback: if fallback:
return NullTranslations() return NullTranslations()
raise IOError(ENOENT, 'No translation file found for domain', domain) raise IOError(ENOENT, 'No translation file found for domain', domain)
# TBD: do we need to worry about the file pointer getting collected?
# Avoid opening, reading, and parsing the .mo file after it's been done # Avoid opening, reading, and parsing the .mo file after it's been done
# once. # once.
result = None result = None
@ -475,7 +474,8 @@ def translation(domain, localedir=None, languages=None,
key = os.path.abspath(mofile) key = os.path.abspath(mofile)
t = _translations.get(key) t = _translations.get(key)
if t is None: if t is None:
t = _translations.setdefault(key, class_(open(mofile, 'rb'))) with open(mofile, 'rb') as fp:
t = _translations.setdefault(key, class_(fp))
# Copy the translation object to allow setting fallbacks and # Copy the translation object to allow setting fallbacks and
# output charset. All other instance data is shared with the # output charset. All other instance data is shared with the
# cached object. # cached object.