Issue #19987: Re-write test_alias_fallback in test_winsound to have two

acceptable outcomes: success or RuntimeError. Without being able to
actually hear whether a sound was played, either one could be right, but
any other error would be a failure.
This commit is contained in:
Zachary Ware 2013-12-16 09:02:41 -06:00
parent 928b9e272d
commit 1007432c95
2 changed files with 9 additions and 8 deletions

View File

@ -158,14 +158,15 @@ class PlaySoundTest(unittest.TestCase):
)
def test_alias_fallback(self):
if _have_soundcard():
# In the absense of the ability to tell if a sound was actually
# played, this test has two acceptable outcomes: success (no error,
# sound was theoretically played; although as issue #19987 shows
# a box without a soundcard can "succeed") or RuntimeError. Any
# other error is a failure.
try:
winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
else:
self.assertRaises(
RuntimeError,
winsound.PlaySound,
'!"$%&/(#+*', winsound.SND_ALIAS
)
except RuntimeError:
pass
def test_alias_nofallback(self):
if _have_soundcard():

View File

@ -160,7 +160,7 @@ Tests
- Issue #19926: Removed unneeded test_main from test_abstract_numbers.
Patch by Vajrasky Kok.
- Issue #19595: Re-enabled a long-disabled test in test_winsound.
- Issue #19595, #19987: Re-enabled a long-disabled test in test_winsound.
- Issue #19588: Fixed tests in test_random that were silently skipped most
of the time. Patch by Julian Gindi.