traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-41521: Replace whitelist/blacklist with allowlist/denylist (GH-21823) 

Rename 5 test method names in test_codecs and test_typing.
This commit is contained in:
Victor Stinner 2020-08-11 15:28:43 +02:00 committed by GitHub
parent fabd7bb8e0
commit 0ee0b2938c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/test/test_codecs.py
View File

@ -2644,7 +2644,7 @@ class TransformCodecTest(unittest.TestCase):
view_decoded = codecs.decode(view, encoding) view_decoded = codecs.decode(view, encoding)
self.assertEqual(view_decoded, data) self.assertEqual(view_decoded, data)
def test_text_to_binary_blacklists_binary_transforms(self): def test_text_to_binary_denylists_binary_transforms(self):
# Check binary -> binary codecs give a good error for str input # Check binary -> binary codecs give a good error for str input
bad_input = "bad input type" bad_input = "bad input type"
for encoding in bytes_transform_encodings: for encoding in bytes_transform_encodings:
@ -2656,14 +2656,14 @@ class TransformCodecTest(unittest.TestCase):
bad_input.encode(encoding) bad_input.encode(encoding)
self.assertIsNone(failure.exception.__cause__) self.assertIsNone(failure.exception.__cause__)
def test_text_to_binary_blacklists_text_transforms(self): def test_text_to_binary_denylists_text_transforms(self):
# Check str.encode gives a good error message for str -> str codecs # Check str.encode gives a good error message for str -> str codecs
msg = (r"^'rot_13' is not a text encoding; " msg = (r"^'rot_13' is not a text encoding; "
r"use codecs.encode\(\) to handle arbitrary codecs") r"use codecs.encode\(\) to handle arbitrary codecs")
with self.assertRaisesRegex(LookupError, msg): with self.assertRaisesRegex(LookupError, msg):
"just an example message".encode("rot_13") "just an example message".encode("rot_13")
def test_binary_to_text_blacklists_binary_transforms(self): def test_binary_to_text_denylists_binary_transforms(self):
# Check bytes.decode and bytearray.decode give a good error # Check bytes.decode and bytearray.decode give a good error
# message for binary -> binary codecs # message for binary -> binary codecs
data = b"encode first to ensure we meet any format restrictions" data = b"encode first to ensure we meet any format restrictions"
@ -2678,7 +2678,7 @@ class TransformCodecTest(unittest.TestCase):
with self.assertRaisesRegex(LookupError, msg): with self.assertRaisesRegex(LookupError, msg):
bytearray(encoded_data).decode(encoding) bytearray(encoded_data).decode(encoding)
def test_binary_to_text_blacklists_text_transforms(self): def test_binary_to_text_denylists_text_transforms(self):
# Check str -> str codec gives a good error for binary input # Check str -> str codec gives a good error for binary input
for bad_input in (b"immutable", bytearray(b"mutable")): for bad_input in (b"immutable", bytearray(b"mutable")):
with self.subTest(bad_input=bad_input): with self.subTest(bad_input=bad_input):

2
Lib/test/test_typing.py
View File

@ -1387,7 +1387,7 @@ class ProtocolTests(BaseTestCase):
self.assertIsSubclass(B, Custom) self.assertIsSubclass(B, Custom)
self.assertNotIsSubclass(A, Custom) self.assertNotIsSubclass(A, Custom)
def test_builtin_protocol_whitelist(self): def test_builtin_protocol_allowlist(self):
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
class CustomProtocol(TestCase, Protocol): class CustomProtocol(TestCase, Protocol):
pass pass